CompatHelper: bump compat for Flux to 0.13 for package test, (keep existing compat) #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranocha
force-pushed
the
compathelper/new_version/2023-03-10-00-06-48-222-01498339475
branch
from
2ef2394 to
1c4739a
Compare
ranocha
requested changes
Mar 10, 2023
sloede
reviewed
Mar 10, 2023
sloede
previously approved these changes
Mar 10, 2023
|
@ranocha There seems to be a new issue now: This is from OrdinaryDiffEq, isn't it? |
|
I will take care of that - it's on my TODO list |
Great, thanks! |
sloede
approved these changes
Jun 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
- Coverage 96.00% 91.42% -4.58%
==========================================
Files 364 364
Lines 30928 30920 -8
==========================================
- Hits 29690 28267 -1423
- Misses 1238 2653 +1415
Flags with carried forward coverage won't be shown. Click here to find out more. |
auto-merge was automatically disabled
February 5, 2024 07:37
Pull request was closed
sloede
deleted the
compathelper/new_version/2023-03-10-00-06-48-222-01498339475
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Fluxpackage from0.13 - 0.13.12to0.13 - 0.13.12, 0.13for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.